[Mellanox] fix sfp issue in reading qsfp_status #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2019 06:12
There is a very low possibility that qsfp_status exists when opening it but doesn't when reading it a bit later. If this occurs an exception is raised. However, this should be treated as "not presence" rather than causing an exception, which can be achieved by putting it into try block.
lguohan
reviewed
Aug 28, 2019
|
retest this, please |
|
Retest broadcom please |
jleveque
approved these changes
Sep 6, 2019
lguohan
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix sfp issue in reading qsfp_status
- How I did it
Move qsfp_status reading into try-block
- How to verify it
Test whether the sfp modules are read correctly.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)